Fix saved config profiles with env overrides#695
Conversation
willccbb
requested review from
JannikSt,
JohannesHa,
burnpiro,
d42me and
kcoopermiller
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b992865029
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
willccbb
force-pushed
the
codex/fix-prime-config-usesave
branch
2 times, most recently
from
861a7fb to
19c3309
Compare
willccbb
force-pushed
the
codex/fix-prime-config-usesave
branch
2 times, most recently
from
07a8e17 to
e7b86e9
Compare
willccbb
force-pushed
the
codex/fix-prime-config-usesave
branch
from
e7b86e9 to
e3c8ea7
Compare
willccbb
force-pushed
the
codex/fix-prime-config-usesave
branch
from
e3c8ea7 to
cf0babf
Compare
willccbb
force-pushed
the
codex/fix-prime-config-usesave
branch
from
cf0babf to
071acdf
Compare
willccbb
changed the title
willccbb
force-pushed
the
codex/fix-prime-config-usesave
branch
from
071acdf to
e3de47f
Compare
willccbb
force-pushed
the
codex/fix-prime-config-usesave
branch
from
e3de47f to
c08cf33
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c08cf3367b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
willccbb
force-pushed
the
codex/fix-prime-config-usesave
branch
from
c08cf33 to
9c8c7c3
Compare
willccbb
force-pushed
the
codex/fix-prime-config-usesave
branch
from
9c8c7c3 to
2fd071a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2fd071a. Configure here.
1 participant
Summary
prime config use <profile>fail when active credential/user/API URL env vars or ambientPRIME_CONTEXTwould mask the selected saved profile.--contextworking forconfig useand restore context state after the command.Testing
uv run ruff check packages/prime/src/prime_cli/core/config.py packages/prime/src/prime_cli/commands/config.py packages/prime/src/prime_cli/main.py packages/prime/tests/test_config_profiles.py packages/prime/tests/test_config_delete.pyuv run ruff format --check packages/prime/src/prime_cli/core/config.py packages/prime/src/prime_cli/commands/config.py packages/prime/src/prime_cli/main.py packages/prime/tests/test_config_profiles.py packages/prime/tests/test_config_delete.pyuv run pytest packages/prime/tests/test_config_profiles.py packages/prime/tests/test_config_delete.py packages/prime/tests/test_switch.py -q